Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded appveyor step #690

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Remove unneeded appveyor step #690

merged 1 commit into from
Jan 2, 2020

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Jan 1, 2020

Summary

Remove an uneeded appveyor step.

Details

The appveyor script always installs ansicon (ANSI control sequences library).

This step can fail sometimes, so removing it should make the build more reliable and faster.

Motivation and Context

I created this PR because this appveyor build failed because of this unnecessary step.

This step can fail sometimes, so removing it should make the build more
reliable and faster.
Copy link
Contributor

@mvz mvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never noticed this failing, but it's always good to remove an unnecessary step.

@mvz mvz merged commit 41ffd30 into master Jan 2, 2020
@mvz mvz deleted the try_fix_appveyor branch January 2, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants