Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Uncouple some of aruba's step definition code #666

Merged
merged 5 commits into from
Aug 24, 2019
Merged

Refactor: Uncouple some of aruba's step definition code #666

merged 5 commits into from
Aug 24, 2019

Conversation

luke-hill
Copy link
Contributor

Summary

Partially fix up the highly coupled / split steps in aruba

Details

Where a step had 4/5/6 block params, I've opted to duplicate the cukes but reduce complexity. I've not done them all, but done sufficiently enough to improve the codebase

Motivation and Context

Partially fixes #640

How Has This Been Tested?

CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@luke-hill luke-hill requested a review from mvz August 13, 2019 15:13
@mvz
Copy link
Contributor

mvz commented Aug 21, 2019

I'll take a look at this this weekend.

mvz
mvz approved these changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@mvz mvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice clean-up and also removes some weird options like allowing "should pass with n failures" 👍.

@mvz mvz merged commit 4150a25 into master Aug 24, 2019
@mvz mvz deleted the refactor/uncouple_aruba_cucumber_steps branch August 24, 2019 09:59
@luke-hill luke-hill mentioned this pull request Sep 25, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvz mvz mvz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up step definitions
2 participants
@luke-hill @mvz