Handle announcing with DebugProcess #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic @announce tag was not tested. This adds a feature test for it.
Avoids returning NotImplementedError and causing later confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handle announcing with the DebugProcess runner
Details
The DebugProcess runner does not implement all methods used by the announcer (and the same goes for the InProcess runner). Catch the resulting NotImplementedError exceptions and print an appropriate message.
Motivation and Context
Issue #563.
How Has This Been Tested?
A cucumber scenario was added.
Types of changes
Checklist: