Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up cuke tags #548

Merged
merged 2 commits into from
Mar 6, 2018
Merged

Clean up cuke tags #548

merged 2 commits into from
Mar 6, 2018

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Mar 6, 2018

Summary

Clean up set of internally used cuke tags and their implementation.

Details

  • Remove one of the ways to indicate need for MRI platform
  • Use only hooks.rb to define platform-related tag handling.
  • Remove unused tags.

Motivation and Context

Clean up stuff.

How Has This Been Tested?

Travis.

Types of changes

  • Refactoring (cleanup of codebase without changing any existing functionality)

olleolleolle
olleolleolle approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it easier to read, for me.

@mvz mvz merged commit 0f31e48 into master Mar 6, 2018
@mvz mvz deleted the clean-up-cuke-tags branch March 6, 2018 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @olleolleolle