Several small fixes and fix for #67 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| it('should merge three adjacent whitespaces', function() { | ||
| nodeContent = [['s', ' '], ['s', ' \n'], ['s', ' \n']]; |
There was a problem hiding this comment.
synthetic test, can't be in real life
There was a problem hiding this comment.
And previous too.
But this kind of tree may be produced on first step in processing and i must ensure that second step will work correctly. We should have both integration and unit tests. This is a unit test.
| }); | ||
|
|
||
| it('should remove empty ruleset', function() { | ||
| assert.equal(comb.processString(' b {} /*123*/'), ' /*123*/'); |
There was a problem hiding this comment.
I meant to insert comment into a rule, not after.
mishanga
added a commit
that referenced
this pull request
Sep 17, 2013
Several small fixes and fix for #67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.