Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace '\n' with os.EOL and add consistency for last new line #524

Closed
obenjiro opened this issue May 29, 2017 · 4 comments
Closed

Replace '\n' with os.EOL and add consistency for last new line #524

obenjiro opened this issue May 29, 2017 · 4 comments
Labels
type: enhancement
Milestone
4.2.0

Comments

@obenjiro
Copy link
Contributor

Let's avoid using platform specific constants directly. And new need to output last new line consistently across the app
@obenjiro obenjiro added this to the 4.2.0 milestone May 29, 2017
@obenjiro obenjiro mentioned this issue May 29, 2017
Merged
@bardware
Copy link

bardware commented Jun 5, 2017

First thing I noticed; inserted line breaks are new line instead of 0D0A

obenjiro added a commit that referenced this issue Jun 11, 2017
@obenjiro
Replace ‘\n’ with os.EOL (#524)
0028e60
@obenjiro
Copy link
Contributor Author

Done partially. We need to detect "line-end" for CSS file and use it instead. Will be done in separate issue

@bardware
Copy link

Will be done in separate issue

I just found this issue addressing the new lines: #367

@obenjiro
Copy link
Contributor Author

@bardware tnx, even more reason to close, since it's duplicate. I fixed output for terminal, but all other places require extra work. Will do that when I got an idea how to handle it. It will be fixed in #367

@snyk-bot snyk-bot mentioned this issue Jan 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
4.2.0
Development

No branches or pull requests
2 participants
@bardware @obenjiro