Improve Rich Text & Code/Markdown heading styling #741
Conversation
|
I also just pushed an update to the CkEditor heading styles which were previously very hard for me to read the different heading levels because they looked the same as unstyled text. Before
After
|
|
For some reason the CkEditor styles aren't applied when printing. I'm trying to figure that out now. |
zicklag
force-pushed
the
feature/markdown-heading-style
branch
2 times, most recently
from
90f8439 to
622232a
Compare
|
Just pushed a fix for the printing styles not being picked up, and I tweaked the ckeditor styles just slightly more to make it match the markdown preview styles:
Also, just curious, if this gets merged, what is the normal release cadence, or when I could expect this to get published to the live instance at cryptpad.fr? |
|
I quickly reviewed this PR before our 4.7.0 release and noticed that it seemed to also affect styles in the code editor itself. It wasn't obvious why this would be the case and I haven't had the opportunity to dig into the problem yet, but I intend to so this can get merged. For future reference, this would be easier to review if it were split into two PRs (for rich text and code), but that's not a blocking issue. |
|
PS: thanks for the effort in the meantime! |
Gotcha. I'll do that in the future.
No problem! Thanks for CryptPad! :) |
ghost
added
Rich Text
mathilde-cryptpad
changed the title
|
@davidbenque what do you think about the proposed changes? Shall we merge them or reject this PR? |
Hey there! This project is very cool!
I just found this today and might be contributing more if I can find the time. For now, here's a quick PR to ( subjectively ) improve the heading sytle in the markdown editor.
Also, this was super easy to get setup for development, which is great! 😃
Before
After