Fix /checkup/ false positive when OnlyOffice is not installed #1731
+51
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAAMON
added
Deployment
wginolas
reviewed
Dec 9, 2024
www/checkup/main.js
Outdated
| @@ -720,12 +725,11 @@ define([ | |||
| }); | |||
|
|
|||
| assert(function (cb, msg) { // FIXME possibly superseded by more advanced CSP tests? | |||
| var url = `/common/onlyoffice/dist/${OOCurrentVersion.currentVersion}/web-apps/apps/spreadsheeteditor/main/index.html`; | |||
| msg.appendChild(CSP_WARNING(url)); | |||
| msg.appendChild(CSP_WARNING(sheetURL)); | |||
There was a problem hiding this comment.
Is no if (ooEnabled) { needed here?
There was a problem hiding this comment.
Fixed! Typo from when i reverted the Prettier formatting.
wginolas
approved these changes
Dec 11, 2024
wginolas
requested changes
Dec 11, 2024
It's because the PR wasn't created from |
AAAMON
force-pushed
the
fix-onlyoffice-checkup
branch
from
4ce0191 to
b5176fa
Compare
|
Fixed |
wginolas
approved these changes
Dec 12, 2024
|
I also tested the fix and found no problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed the issue described here: #1702.