Formatted tables and strikethrough text in Pad .md exports #1720
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zuzanna-maria
commented
Nov 22, 2024
zuzanna-maria
commented
- Pad documents exported in .md format now include table and strikethrough text formatting (fixes Exporting tables to markdown does not work #1531)
zuzanna-maria
added
the
Ready to Review
yflory
removed
the
Ready to Review
zuzanna-maria
added
the
Ready to Review
yflory
requested changes
Dec 5, 2024
www/pad/export.js
Outdated
| @@ -96,7 +96,34 @@ define([ | |||
| if (ext === ".md") { | |||
| var md = Turndown({ | |||
| headingStyle: 'atx' | |||
| }).turndown(toExport); | |||
| }).addRule('table', { | |||
| filter: ['tr'], | |||
There was a problem hiding this comment.
Small indentation issue starting here
www/pad/export.js
Outdated
| replacement: function (content, node) { | ||
| var indexOf = Array.prototype.indexOf; | ||
| var index = indexOf.call(node.parentNode.childNodes, node); | ||
| var rowContent = node.innerHTML.replace(/<td>/g, '').replace(/<br>/g, ' ').split('</td>'); |
There was a problem hiding this comment.
- Removing the
<br>here will remove new lines inside cells. This is acceptable since currently exports are not working but it would be nice to be able to fix this. - This won't work if the table contains "header" cells which are
<th>instead of<td> - I think it would be easier to work with the DOM elements directly instead of treating the HTML as a string
yflory
added
Ready to Test
yflory
approved these changes
Dec 9, 2024
|
The markdown tables seem to be missing a pipe character at the start of rows that have content, and at the end of the empty row after the header. The CryptPad Code app seems to render the table anyways, but other apps might not (I tested Typora which didn't work). Github also seems to be fine with the example below, so maybe this is a niche issue with the apps I use and my way of writing tables. original Rich Text table: Markdown export: Rendered on GitHub:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.