Skip to content

[DRAFT] CI: Enable testing on Windows #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
amotl wants to merge 26 commits into
base: main
Choose a base branch
from
+80 −13
Draft

[DRAFT] CI: Enable testing on Windows #388

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
1b7bbb6
Satisfy testing on macOS
amotl Oct 28, 2020
f2b5c7b
CI: Adjust CrateDB version in versions.cfg only on Linux
amotl Nov 3, 2020
edeb599
Attempt to mitigate "Failed to start Crate instance in time"
amotl Nov 3, 2020
18b332f
CI: Enable testing on Windows
amotl Nov 3, 2020
a9920f0
CI: Use "bash" when running on Windows
amotl Nov 3, 2020
ea3fee2
CI: Disable firewall on Windows before running tests
amotl Nov 3, 2020
769c627
CI: Attempt to mitigate CrateDB bootstrap errors on Windows
amotl Nov 3, 2020
9cba456
CI: Another attempt to mitigate "Unrecognized Windows Sockets error: …
amotl Nov 3, 2020
f589521
CI: Another attempt to mitigate "Unrecognized Windows Sockets error: …
amotl Nov 3, 2020
3e788da
CI: Disable IPv6 on Windows
amotl Nov 3, 2020
3a1c22f
CI: Attempt to fix Windows by setting SystemRoot env variable
amotl Nov 5, 2020
a2c86cf
CI: Fix Windows path handling
amotl Nov 5, 2020
c87dc71
CI: Improve logging to find out about any errors when starting CrateDB
amotl Nov 5, 2020
39fbad7
CI: Improve logging to find out about any errors when starting CrateDB
amotl Nov 5, 2020
8717536
CI: Fix path computation for Windows again
amotl Nov 5, 2020
0d0c4c4
CI: Give test layer some more time to tear down on Windows
amotl Nov 5, 2020
100aa9f
CI: Add comment
amotl Nov 5, 2020
18e60c3
CI: Give test layer some more time to tear down on Windows
amotl Nov 5, 2020
2a73fdd
CI: Ignore test layer timeout on tear down on Windows
amotl Nov 5, 2020
0e5533f
CI: Improve layer shutdown behaviour
amotl Nov 5, 2020
04ebe12
CI: Adjust GHA/Windows
amotl Nov 5, 2020
cb54ce8
CI: GHA/Windows again
amotl Nov 5, 2020
f5abad9
fixup! CI: Adjust CrateDB version in versions.cfg only on Linux
amotl May 25, 2022
7f8ca8b
Sandbox: Update zc.buildout to 2.13.7
amotl May 25, 2022
7d45ba0
CI: Don't fail fast when invoking the test matrix
amotl May 25, 2022
73b94ad
CI: Fix finding `bin/test` on Windows
amotl May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CI: Fix path computation for Windows again
  • Loading branch information
@amotl
amotl committed May 25, 2022
commit 87175364c1a5cf0c7c12ab1a11e7841ed6d679cc
6 changes: 6 additions & 0 deletions src/crate/client/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
import json
import os
import socket
import pathlib
import sys
import unittest
import doctest
from pprint import pprint
Expand Down Expand Up @@ -166,7 +168,11 @@ def setUpWithCrateLayer(test):
cursor.execute(stmt)
assert cursor.fetchall()[0][0] == 1

# Compute path to file for data loading.
data_path = docs_path('testing/testdata/data/test_a.json')
if sys.platform == 'win32':
data_path = pathlib.PureWindowsPath(data_path).as_uri()

# load testing data into crate
cursor.execute("copy locations from ?", (data_path,))
# refresh location table so imported data is visible immediately
Expand Down
4 changes: 0 additions & 4 deletions src/crate/testing/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
# software solely pursuant to the terms of the relevant commercial agreement.

import os
import pathlib
import sys
import unittest
import doctest
import tempfile
Expand All @@ -35,8 +33,6 @@ def docs_path(*parts):
os.path.dirname(os.path.dirname(__file__)), *parts
)
)
if sys.platform == 'win32':
path = pathlib.PureWindowsPath(path).as_uri()
return path


Expand Down