Add reference to Berg’s hashed deterministic Miller–Rabin base work #1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a short reference section linking to Steven Berg’s work on hashed deterministic Miller–Rabin base selection, as requested in issue cp-algorithms#1561. The linked resource provides optimized base buckets for 32–64 bit primality testing, extending earlier deterministic base research and offering an option for further reading. Fixes cp-algorithms#1561.
Contributor
|
This doesn't seem to add much imo. |
Member
|
It reduces number of test calls to guarantee that the test works on 64-bit numbers from 7 to 3. It's a 2x improvement in practice, which is pretty neat, but takes up a lot of source code to store bases tables. Might be good to explain it a bit further in the text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a short reference section linking to Steven Berg’s work on hashed deterministic Miller–Rabin base selection, as requested in issue #1561.
The linked resource provides optimized base buckets for 32–64 bit primality testing, extending earlier deterministic base research and offering an option for further reading.
Fixes #1561.