-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
make language consistent #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
make language consistent #1563
Conversation
|
|
||
| We can find arbitrary range sums by computing the prefix sums for $l-1$ and $r$ and taking the difference of them again. | ||
|
|
||
| ```python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we actually keep both Python and C++?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want it for the whole fenwick module or just this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whole if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.... can you approve the workflow so i can see the preview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previews are available on the website website contributing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preview looks good, can you approve the workflow so i can see if that error is resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't made any changes in test fenwick file..... The build is getting failed bcz of that missing .h files
try messing with space.
pretty sure spaces are screwing up test file generation.
|
It looks like the extract_snippets.py is not matching indented named C++ files. Maybe we should change that extractor @adamant-pwn ? I've resolved the error in a cursory way by unindenting the named C++ files (perhaps we should uniformly unindent the code blocks? |
|
I screwed up. I need to undo that force push. It seems like stuff finally worked locally but I'm dumb and somehow incorporated incorrect changes (lack of updates). |
|
Hmmm... I'm gonna revisit this. I screwed up incorporated old code into a push. It was working locally (tabs on the fenwick article). If you're interested @Sosuke23 , the https://cp-algorithms.com/contrib.html is useful. You can run the website locally and test it locally. |
i think it is better to make coding language consistent.