Skip to content

Conversation

@A-stick-bug
Copy link

Added sqrt decomposition code that supports both range updates and range queries in O(sqrt(n))

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (for commit 603e7ea):

https://cp-algorithms--preview-1204-f0s8g2k4.web.app

(expires 2023-12-27T02:26:54.469890884Z)

@adamant-pwn
Copy link
Member

Thanks for the pull request! I have few concerns here:

  1. At the moment the implementation is just dumped in the middle of the paragraph without any further explanation. The paragraph itself uses names $b$ and $c$ for arrays, which is obviously inconsistent with the names used in the code, and should be fixed to provide a better continuity.
  2. I'm not sure whether Python implementation is particularly useful. Was it tried on specific problems? How does it fare against C++ implementations? Sqrt decomposition often has a large constant time factor, and with Python it might be even worse...

@adamant-pwn
Copy link
Member

@A-stick-bug hi, do you plan any further work on this pull request?

@A-stick-bug
Copy link
Author

A-stick-bug commented Jan 5, 2024 via email

@adamant-pwn adamant-pwn deleted the branch cp-algorithms:main October 14, 2024 18:52
@adamant-pwn adamant-pwn reopened this Oct 14, 2024
@adamant-pwn adamant-pwn changed the base branch from master to main October 14, 2024 19:20
@github-actions
Copy link
Contributor

Preview the changes for PR #1204 (for commit 8f52f11) at https://gh.cp-algorithms.com/1204/.

@mhayter
Copy link
Contributor

mhayter commented Apr 16, 2025

updates?

@mhayter
Copy link
Contributor

mhayter commented Jun 28, 2025

Last ping @A-stick-bug

@A-stick-bug
Copy link
Author

Should be good now, I fixed all the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants