Skip to content

FIX sorting with datetime from Nextras ORM #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stanislav-cervenak wants to merge 2 commits into from
Closed

FIX sorting with datetime from Nextras ORM #917

stanislav-cervenak wants to merge 2 commits into from

Conversation

@stanislav-cervenak
Copy link

@stanislav-cervenak stanislav-cervenak commented Sep 2, 2020 

Error
Cannot use object of type Nextras\Dbal\Result\Row as array

screencapture-mrhoreca-localhost-8828-locale-translator-my-category-type-2020-09-02-19_04_42

@stanislav-cervenak
Update ArrayDataSource.php
ecec5c4 
```
Error
Cannot use object of type Nextras\Dbal\Result\Row as array
```
@stanislav-cervenak
Update ArrayDataSource.php
8e80413 
Edit tabs
@f3l1x
Copy link
Member

f3l1x commented Nov 24, 2021

Can you please add some tests?

@radimvaculik
Copy link
Member

radimvaculik commented Jan 25, 2023

@suchoproduction Could you rebase the branch and add some tests, please? Thanks.

@radimvaculik
Copy link
Member

radimvaculik commented Aug 22, 2023

@hrach Could you take a look at it, please?

hrach
hrach approved these changes Aug 22, 2023
View reviewed changes
Copy link

@hrach hrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radimvaculik
Copy link
Member

radimvaculik commented Aug 22, 2023

@suchoproduction Please, rebase.

@f3l1x
Copy link
Member

f3l1x commented Mar 12, 2025 •
edited
Loading

I think it's already done. Feel free to reopen this PR, if you think it's not.

b910672

@f3l1x f3l1x closed this Mar 12, 2025
f3l1x added a commit that referenced this pull request Mar 12, 2025
@f3l1x
ArrayDataSource: improve sorting [ref #917]
b910672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hrach hrach hrach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stanislav-cervenak @f3l1x @radimvaculik @hrach