Group actions - confirm dialog #1058
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidjo17
force-pushed
the
upd/group-action-confirmation
branch
from
a275b7a to
64b5c0b
Compare
Member
|
@paveljanda @f3l1x anything against this? looks simple and useful |
paveljanda
reviewed
Jan 2, 2023
Member
|
@nidjo17 Hi, could you rebase your branch against |
nidjo17
force-pushed
the
upd/group-action-confirmation
branch
from
f87b6ed to
1a2fa59
Compare
Contributor
Author
Hi @radimvaculik it's rebased, thank you. |
radimvaculik
requested changes
Jan 27, 2023
nidjo17
force-pushed
the
upd/group-action-confirmation
branch
from
f2ee32d to
f4a98fe
Compare
Member
|
@paveljanda Please, check it. Thanks. |
radimvaculik
approved these changes
Jan 27, 2023
nidjo17
force-pushed
the
upd/group-action-confirmation
branch
from
30cf20d to
2aa25b6
Compare
Member
|
@paveljanda Cloud you check this PR, please? |
Member
|
I think @f3l1x will have to review that as since rewriting frontend script entirely, this will have to be included. |
Member
|
@f3l1x Ping. |
Member
|
I would wait for the next version of JS/CSS and implement it there. |
Member
|
@nidjo17 Could you rebase, please? Cc @lilianalillyy |
nidjo17
force-pushed
the
upd/group-action-confirmation
branch
from
2aa25b6 to
7443936
Compare
nidjo17
force-pushed
the
upd/group-action-confirmation
branch
from
7443936 to
1c36c3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to define confirmation dialog for group actions. I think it's not currently supported.