Fixing custom classes on checkbox in inline edit #1049
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am having the same issue, I think that in addition to your fix, there should be a condition for TextBase and SelectBox. |
Member
|
Good for me! 👍 @paveljanda / @f3l1x Please merge it. |
Member
|
Please rebase your PR. |
Spilky
force-pushed
the
inline-edit-checkbox-classes-bug
branch
from
d22f09e to
bbbd24e
Compare
Contributor
Author
|
@f3l1x done. There is error for PHPStan and it is not related to my PR: |
Member
- `\Nette\Forms\Controls\Checkbox::getControl` returns label part and control part like one ``\Nette\Utils\Html` and then `$control->getControl()->getAttribute('class')` is always null and custom defined classes are always overwritten by `$control->setAttribute('class', 'form-control input-sm form-control-sm');`
- fixed by using `\Nette\Forms\Controls\BaseControl::getControlPrototype` which always returns only control part without label part
Spilky
force-pushed
the
inline-edit-checkbox-classes-bug
branch
from
bbbd24e to
1e25300
Compare
Contributor
Author
|
@radimvaculik @f3l1x rebased again. All checks are successful. Please merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\Nette\Forms\Controls\Checkbox::getControlreturns label part and control part like one\Nette\Utils\Htmland then$control->getControl()->getAttribute('class')is always null (because it takes class from label) and custom defined classes are always overwritten by$control->setAttribute('class', 'form-control input-sm form-control-sm');\Nette\Forms\Controls\BaseControl::getControlPrototypewhich always returns only control part without label part