Skip to content

Fix #6551 Use action getLatestApplicableVersionAndRev only when needed #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpilgrem merged 1 commit into from
Apr 6, 2024
Merged

Fix #6551 Use action getLatestApplicableVersionAndRev only when needed #6552

mpilgrem merged 1 commit into from
Apr 6, 2024

Conversation

@mpilgrem
Copy link
Member

@mpilgrem mpilgrem commented Apr 6, 2024

  • Any changes that could be relevant to users have been recorded in ChangeLog.md.
  • The documentation has been updated, if necessary

Please also shortly describe how you tested your change. Bonus points for added tests! Relying on CI.

@wraithm
Copy link
Contributor

wraithm commented Apr 6, 2024

@mpilgrem I confirmed that this gives a ~7-8 s no-op build time on our repo! This does indeed fix a solid chunk of #6551. Thank you! :) There might be something else that is accounting for that additional 7-8 s that stack-2.7.5 isn't doing (which usually takes <2 s).

@wraithm wraithm mentioned this pull request Apr 6, 2024
Closed
@mpilgrem mpilgrem merged commit 80e2994 into master Apr 6, 2024
@mpilgrem mpilgrem deleted the fix6551 branch April 6, 2024 18:58
@mpilgrem mpilgrem mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wraithm wraithm wraithm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpilgrem @wraithm