Optimize ScalaJSModule and cache IRFileCache
#2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Sep 25, 2023
Done ✅ |
gzm0
reviewed
Sep 26, 2023
| @@ -150,14 +145,15 @@ class ScalaJSWorkerImpl extends ScalaJSWorkerApi { | |||
| ) | |||
| else withModuleSplitStyle | |||
|
|
|||
| StandardImpl.clearableLinker(withOutputPatterns) | |||
| val linker = StandardImpl.clearableLinker(withOutputPatterns) | |||
| val irFileCache = StandardImpl.irFileCache().newCache | |||
There was a problem hiding this comment.
The IRFileCache is capable to cache IR across different linker instances.
So ideally, you have a single instance of irFileCache() in the entire build (and a newCache per linker). This ensures that, for example, the Scala library is loaded only once. Otherwise you might see very high memory usage.
sjrd
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various optimizations in
ScalaJSModuleandScalaJSWorkerImpl.Changes:
sjsirfiles andjarfiles manually and let the Scala.js toolchain do it withPathIRContainer.fromClasspath(runClasspath)passing the full runClasspathIRFileCache.Cachetogether with the linker so it can be reused in multiple invocations offastLinkJSPull request: #2783