improve suffixes + fix .rc compilation with MinGW #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honor CMake's
CMAKE_DEBUG_POSTFIXwhen formingoutput filenames. Can be customized freely.
detect when static lib and implib would clash (= MSVC) and apply
a default "s" suffix to the static lib in that case.
allow to override the static lib suffix via
ZLIB_STATIC_LIB_SUFFIX.This also overrides the "s" above.
-DGCC_WINDRESis required forwindres. Make sure to pass itwhen detected. (FWIW this PP macro/logic seems unnecessary/obsolete,
but that's not a CMake issue.)
build
zlib1.dllright away on Windows.Instead of renaming to that on install.
Derive
1from the zlib version.