Fix missing NONC tag in responses and wrong type #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevalenta
reviewed
Nov 4, 2024
lukevalenta
approved these changes
Nov 4, 2024
Contributor
lukevalenta
left a comment
lukevalenta
left a comment
There was a problem hiding this comment.
Looks good to me--thank you!
Contributor
|
Some of the CI tests are failing--maybe test vectors need to be updated. I'll investigate soon. |
cjpatton
reviewed
Dec 2, 2024
Contributor
cjpatton
left a comment
cjpatton
left a comment
There was a problem hiding this comment.
Tests should pass after regenerating the test vectors:
cd protocol && go generate
Contributor
Author
|
Nits fixed and test vectors updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs found during the IETF Hackathon in Dublin.