This repository was archived by the owner on Feb 9, 2024. It is now read-only.
fix URL parsing in serveSinglePageApp #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes an issue in serveSinglePageApp where the raw `request.url` string is being used as part of a conditional to retrieve static content - if a query parameter is set, it breaks the URL lookup. credit to @sgiacosa who wrote this code in cloudflare#72 - this PR is a _very slight_ adaptation of his code sample! closes cloudflare#72
exvuma
approved these changes
Mar 31, 2020
|
@signalnerve @victoriabernard92 Please consider releasing a new version with this bug fix. Thank you- |
|
@pilwon working to release this week sorry for the delay! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes an issue in serveSinglePageApp where the raw
request.urlstring is being used as part of a conditional to retrieve static content - if a query parameter is set, it breaks the URL lookup. credit to @sgiacosa who wrote this code in #72 - this PR is a very slight adaptation of his code sample!closes #72