This repository was archived by the owner on Feb 9, 2024. It is now read-only.
Support ES Modules. #261
Merged
Support ES Modules. #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR provides a possible solution for getting Workers Sites working with ES Module workers. This approach is not as invasive as other approaches.
Usage:
```
import manifestJSON from '__STATIC_CONTENT_MANIFEST'
const manifest = JSON.parse(manifestJSON)
export default {
fetch(request, env, ctx){
return await getAssetFromKV({request, waitUntil: ctx.waitUntil}, {
ASSET_NAMESPACE: env.ASSET_NAMESPACE,
ASSET_MANIFEST: manifest
})
// ...
}
}
```
I'll also send a PR to wrangler that adds the manifest as a text module to the worker.
Contributor
Author
|
You don't even have to merge this PR really, just to be more accurate about the type signature |
SukkaW
suggested changes
Nov 7, 2021
Comment on lines
+106
to
+110
|
|
||
| type Evt = { | ||
| request: Request | ||
| waitUntil: (promise: Promise<any>) => void | ||
| } |
Contributor
There was a problem hiding this comment.
Why custom Evt type? You know @cloudflare/workers-types will eventually release a new version, right?
Contributor
Author
There was a problem hiding this comment.
I chose the word "Evt" to be familiar, and @cloudflare/workers-types won't ever define the types for kv-asset-handler.
Closed
Cherry
approved these changes
Nov 9, 2021
Contributor
Cherry
left a comment
Cherry
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a possible solution for getting Workers Sites working with ES Module workers. This approach is not as invasive as other approaches, so isn't as risky either.
Usage:
I'll also send a PR to wrangler that adds the manifest as a text module
__STATIC_CONTENT_MANIFESTto the worker.cc @xortive Is this approach right? It's following your comment here cloudflare/wrangler-legacy#1938 (comment)