This repository was archived by the owner on Feb 9, 2024. It is now read-only.
Allow changing pathIsEncoded through options #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry
reviewed
Sep 24, 2021
Contributor
Cherry
left a comment
Cherry
left a comment
There was a problem hiding this comment.
Thanks for the PR!
My understanding of this issue is that this line should take care of that, and then forecfully override pathIsEncoded to true, even without your changes. Is there an example you can share where this isn't the case, and manually setting pathIsEncoded to true is required?
Contributor
Author
|
@Cherry if |
Contributor
Thanks, that makes total sense. I'll merge and see if we can get a new version published next week. Thanks again for the contribution! |
Cherry
approved these changes
Sep 26, 2021
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
mapRequestToAsset, it encodes the URL / key and will never check the KV store for the decoded key.This adds the ability to set
pathIsEncodedto true, which will decode the URL before getting it from the KV.