This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Frank/#165 fix #166
Merged
Frank/#165 fix #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuc
reviewed
Feb 2, 2021
harrishancock
approved these changes
Feb 4, 2021
xtuc
approved these changes
Feb 5, 2021
|
Issue cloudflare/workers-sdk#4975 needs to be investigated before proceeding |
|
@shagamemnon would we be in better shape than we are today if this PR was merged in the meantime? |
|
@koeninger this is ready now. Can you squash the commits? |
|
@shagamemnon cool thanks, squashed + merged |
This was referenced Mar 16, 2021
xiaolanglanglang
pushed a commit
to xiaolanglanglang/kv-asset-handler
that referenced
this pull request
May 18, 2021
* defined response status on cached responses. fixes 165 * updated mocks and added tests for range requests * fixed range request test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165 :)