Fix grpc transcoding bugs for unknown fields #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wayne Zhang <[email protected]>
Contributor
Author
|
Please review this change |
Signed-off-by: Wayne Zhang <[email protected]>
|
LGTM! |
Contributor
Author
nareddyt
reviewed
May 16, 2020
nareddyt
previously approved these changes
May 17, 2020
Contributor
nareddyt
left a comment
nareddyt
left a comment
There was a problem hiding this comment.
LGTM (but see if we can add a t test)
Signed-off-by: Wayne Zhang <[email protected]>
Signed-off-by: Wayne Zhang <[email protected]>
qiwzhang
commented
May 17, 2020
| } | ||
| types { | ||
| name: "endpoints.examples.bookstore.UnknownBook" | ||
| fields { |
Contributor
Author
There was a problem hiding this comment.
FYI, I manually deleted "unknown" field and "UknownMsg" from the service config.
qiwzhang
commented
May 17, 2020
| my $response1 = ApiManager::http_get($NginxPort,'/unknownbook?key=this-is-an-api-key'); | ||
|
|
||
| # With bug in https://github.com/cloudendpoints/esp/issues/795, the first field | ||
| # after the uknown is discarded. Once the bug is fixed, use follow correct result. |
Contributor
Author
There was a problem hiding this comment.
Without the fix, the first field "known_int" is discarded. With the fix, all fields are there
Signed-off-by: Wayne Zhang <[email protected]>
nareddyt
previously approved these changes
May 18, 2020
TAOXUY
reviewed
May 18, 2020
Signed-off-by: Wayne Zhang <[email protected]>
TAOXUY
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Zhang [email protected]
Fixes #795.
It is based on #796