Add ckan user clean command #7241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now I'm trying to keep a logic that do not delete the user if the image cannot be deleted. (Permission issues, ..., ?) This is to avoid leaving unreferenced images in the store. |
|
The second issue I'm getting is that this logic is aggressive and considers a user account as spam if they have a wrong file in the image. What about false positives? What if the administrator forgets one mimetype? |
Co-authored-by: Adrià Mercader <[email protected]>
|
Done @amercader ! Failing Cypress test seems unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7225 part of #7208
Proposed fixes:
This PR adds a new command
ckan clean usersthat will scan the system for users with invalid images and delete both the image and the user from the database.Invalid images are all images that doesn't contain allowed mimetypes set in
ckan.upload.user.mimetypesconfig option.Features:
Please [X] all the boxes above that apply