Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has served CKAN very well but in 2.10 is time to start saying goodbye to the venerable Recline-based views. Recline hasn't been maintained in many years, and it doesn't even have its own repository now.
The DataTables view is a much more solid replacement for tabular data, and for the functionality that will be lost (generate (crappy) graphs or maps from tabular data) there are more modern alternatives maintained elsewhere (eg from Keitaro or Datopian). The other thing that Recline offered that has no immediate replacement is the ability to preview tabular data not present in the DataStore via the DataProxy service but this has always proven very unreliable and the source of confusion for users, so again I think it's worth deprecating it.
This PR does a bit of cleanup and it mainly includes:
datatables_view
as a default view to be created (if loaded). I didn't add it as default tockan.plugins
as without thedatastore
one (andxloader
) it won't work, but happy to discussIt doesn't remove the actual plugins, which we can do later on.