Expose check_ckan_version to templates #6741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zharktas
force-pushed
the
expose_check_ckan_version
branch
from
6515395 to
f5b94ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fixes:
Currently extension templates use h.ckan_version() which returns a string and do various splitting operations to get it to work with 2.10. This exposes toolkit method check_ckan_version which essentially does comparison on lists, for example between [2, 10, 0] and [2, 9, 5].
This could be backported even though we have "no new features policy", for extension to have simpler multiple version support.
Features:
Please [X] all the boxes above that apply