Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6521]Upload.__init__ relies too much on makedirs #6578

Conversation

TomeCirun
Copy link
Contributor

Fixes #6521

Proposed fixes:

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

Copy link
Contributor

@kowh-ai kowh-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iv'e tested this change on all possible iterations I can think of...looks good to me

@amercader amercader merged commit 775ab84 into ckan:master Dec 20, 2021
raise
# check if the storage directory is already created by
# the user or third-party
if os.path.isdir(self.storage_path):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload.__init__ relies too much on makedirs
5 participants