Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracking.js module prevent links to be opened in new tabs #6384

Merged
merged 2 commits into from
Sep 10, 2021
Merged

tracking.js module prevent links to be opened in new tabs #6384

merged 2 commits into from
Sep 10, 2021

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Sep 9, 2021

The current module overrides the default action of click() events with a location.href = url; call when the ajax call is completed. This implementation will cause some buggy behavior if the user wants to open the link in a new tab.

Example

<!-- This will open the link in a new tab -->
<a href="http://www.example.org/" target="_blank">Useless Link</a>

<!-- This will open the link in the current tab -->
<a class="resource-url-analytics" href="http://www.example.org/" target="_blank">Useless Link</a>

@amercader amercader self-assigned this Sep 10, 2021
@amercader amercader merged commit 91f6924 into ckan:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amercader amercader

Labels
zBackport 2.7.12 zBackport 2.8.9 zBackport 2.9.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdelboca @amercader