Clean _make_menu_item helper #6263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good @pdelboca but we should add a note to the CHANGELOG (a |
|
Done @amercader ! Let me know if that's okay :)
|
|
I see that there are still warnings for the old route style, saying that is deprecated, but it has been dropped instead: old code will give errors. Lines 985 to 999 in bb5e40c Should such message be changed? |
|
Will this be backported to 2.9? |
nickumia-reisys
added a commit
to GSA/ckanext-datagovtheme
that referenced
this pull request
Apr 18, 2023
Reference: ckan/ckan#6263
nickumia-reisys
added a commit
to GSA/ckanext-usmetadata
that referenced
this pull request
Apr 20, 2023
Reference: ckan/ckan#6263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to clean the helpers to build navigation bars and some old code and configs that are now obsolete.
config['routes.named_routes']should be straight forward since we don't require a mapping anymore. (assuming that all templates are updated to use flask routes when creating nav links.__make_menu_itemwill no longer raise an exception if the helper (in the template) is missing a required argument for the endpoint. I think this is an acceptable tradeoff aiming to clean lot of legacy code that it is still tied to old Pylons logic.