Do not rely on error message when selecting validator signature #6048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardi
reviewed
Apr 27, 2021
wardi
reviewed
Apr 27, 2021
wardi
reviewed
May 11, 2021
wardi
reviewed
May 11, 2021
amercader
added a commit
to ckan/ckanext-xloader
that referenced
this pull request
Jun 11, 2021
amercader
added a commit
to ckan/ckanext-xloader
that referenced
this pull request
Oct 1, 2021
Jin-Sun-tts
added a commit
to GSA/ckanext-usmetadata
that referenced
this pull request
Apr 20, 2023
reference: ckan/ckan#6048
nickumia-reisys
added a commit
to GSA/ckanext-usmetadata
that referenced
this pull request
Apr 20, 2023
This complements the previous update.. ckan/ckan#6048
bellisk
added a commit
to opendatazurich/ckanext-stadtzh-theme
that referenced
this pull request
Aug 30, 2023
Necessary as of ckan/ckan#6048.
bellisk
added a commit
to opendatazurich/ckanext-stadtzh-harvest
that referenced
this pull request
Aug 30, 2023
Necessary as of ckan/ckan#6048.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of validators relies on error messages when validators applied.
Instead, it will be more obvious to check the number of arguments that are expected by the validator - after migration to py3 it's possible via
inspect.signature.