Skip to content

Fix upload log activity sorting #5827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2021
Merged

Fix upload log activity sorting #5827

merged 1 commit into from
Jan 19, 2021

Conversation

jqnatividad
Copy link
Contributor

Fixes #5826.

Proposed fixes:

Use jinja2's built-in sort filter to sort by timestamp.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

pdelboca
pdelboca approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@pdelboca pdelboca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @amercader @jqnatividad !

@amercader
Copy link
Member

Thanks

As an aside the, templates-bs2 in DataPusher can be removed

@amercader amercader merged commit 7eb25a8 into ckan:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdelboca pdelboca pdelboca approved these changes

Assignees

@pdelboca pdelboca

Labels
zBackport 2.7.10 zBackport 2.8.7 zBackport 2.9.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource datastore upload log does not list activities by datetime order
3 participants
@jqnatividad @amercader @pdelboca