[#5698] Filter activities from user at the database level #5699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5698 The `ckan.hide-activity-from-users` configuration option allows you to define the users that you don't want to show activities from on the various activity feeds. It defaults to the internal site user as this is generally used to perform bulk internal processes like harvesting and you don't want to flood the activity stream with their operations. The problem is that we first get the relevant activities from the database and then filter these activities in Python based on the users in the config option. This means that if more activities from the site user were performed than the limit requested, they are fltered out and you get an empty feed, eventhough the activities are still there. These moves the filtering to the model queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5698
The
ckan.hide-activity-from-usersconfiguration option allows you to define the users that you don't want to show activities from on the various activity feeds. It defaults to the internal site user as this is generally used to perform bulk internal processes like harvesting and you don't want to flood the activity stream with their operations.The problem is that we first get the relevant activities from the database and then filter these activities in Python based on the users in the config option.
This means that if more activities from the site user were performed than the limit requested, they are filtered out and you get an empty feed, even though the activities are still there.
These moves the filtering to the model queries so the actions already get filtered lists with the relevant activities.