Allow passing arguments to the RQ enqueue_call function #5208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now you can only pass the `timeout` argument to the RQ `enqueue_call` invocation that we use on `toolkit.enqueue_job()`, but there are other useful arguments that can be passed, like `depends_on`, `ttl` etc Rather than explicitly allow just one of them, it's better to just pass through all of them.
|
Remove the timeout kw |
As it can now be passed as part of the `rq_kwargs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now you can only pass the
timeoutargument to the RQenqueue_callinvocation that we use ontoolkit.enqueue_job()(added in #4601), but there are other useful arguments that can be passed, likedepends_on,ttletcRather than explicitly allow just one of them, it's better to just pass through all of them.
This is backwards compatible, so I proposed we backport it to at least 2.8