-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade psycopg2, fixes ckan/ckan#4837 #4841
Conversation
The test errors seem to result from the same source as in django: lcd1232/django-postgrespool2#11. The issue is described in a PR to the same repository lcd1232/django-postgrespool2#12. Trying to find out where to insert the same fix: https://github.com/lcd1232/django-postgrespool2/pull/12/files#diff-81ec40a918dd202e487e160513255b32R56 |
We won't backport the requirement as it's too risky, but we will mention it on the CHANGELOG. Does this make sense @bzar ? |
Yes, that makes sense. There's no telling what other non obvious side effects the upgrade has and it shouldn't for now be done unless it's necessary. The compatibility fix should work either way. |
Some users might find libssl issues (see #4837) for which an upgrade in psycopg2 is required. While we are not porting the requirement upgrade to 2.8, we make this change which is backwards compatible with psycopg2 2.7.3.2 (CKAN 2.8 pinned version) in case someone needs to upgrade the requirement in their environment. Just in case we fall back to the old syntax if there is an AttributeError.
Added just the code change in 2.8 as agreed (f9aaf91). Apparently the new syntax (3 |
Hi, when to release a new 2.8.x version to use psycopg2 2.8.4? Also, requests version upgrade, and in datapusher. Regards |
Note that for backporting as far back as 2.6 File "/usr/lib/ckan/local/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 435, in do_execute
cursor.execute(statement, parameters)
sqlalchemy.exc.DBAPIError: (UndefinedTable) relation "user" does not exist
LINE 2: FROM "user"
... |
Some users might find libssl issues (see #4837) for which an upgrade in psycopg2 is required. While we are not porting the requirement upgrade to 2.8, we make this change which is backwards compatible with psycopg2 2.7.3.2 (CKAN 2.8 pinned version) in case someone needs to upgrade the requirement in their environment. Just in case we fall back to the old syntax if there is an AttributeError.
Fixes #4837
Proposed fixes:
Upgrade psycopg2 to version 2.8.2
Features:
Please [X] all the boxes above that apply