Fix UnicodeDecodeError on abort fucntion #4829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This was referenced Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
UnicodeDecodeError occurs when rendering error_document_template.html in non-english such as Korean, Chinese or Japan...
File "/usr/lib/ckan/venv/src/ckan/ckan/templates/error_document_template.html", line 8, in block "primary" {{ content}} UnicodeDecodeError: 'ascii' codec can't decode byte 0xec in position 0: ordinal not in range(128)Expect : 이 페이지를 보기 위한 권한 없음(Not authorized to see this page)
Actual : Internal Server Error
Proposed fixes:
This is because detail of the error are encoded as utf8 before executing the flask_abort function.
Unlike pylons_abort, flask_abort does not use WebOb, so it does not seem necessary to encode it before calling flask_abort.
Features:
Please [X] all the boxes above that apply