Fix Explore button not working #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. |
|
check if the hover effect still works |
|
@smotornyuk I checked this one, and the hover effect works, meaning the cursor changes on button hover. |
|
There's also some a11y issue with tags missing an href. Something about screen readers not seeing them as proper links. |
|
@wardi Now when I think better about this one, it doesn't make sense to me to use an I suggest to change it to use |
|
Verified |
amercader
added a commit
that referenced
this pull request
Apr 30, 2021
amercader
added a commit
that referenced
this pull request
Apr 30, 2021
u10313335
added a commit
to depositar/ckan
that referenced
this pull request
Jun 18, 2021
fostermh
pushed a commit
to cioos-siooc/ckan
that referenced
this pull request
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue appears only in master.
When jQuery was upgraded to v3, the Explore button stopped working in a dataset page.
This PR fixes that.