-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive master #1935
Responsive master #1935
Conversation
@johnmartin, just to clarify, is the target of this master? If so can you edit the issue title to avoid confusion? Thanks |
@amercader Agreed. It's for master, so I've updated the title. |
@johnmartin to review |
@nigelbabu Can you remember what the context of bf726c1 was? |
Yep. Please revert that change. It was only because Sam couldn't get it Nigel Babu On 18 September 2014 19:45, John Martin [email protected] wrote:
|
Note to people with custom themes: If you've changed the Also: There's a few more bootstrap classes (especially for grid layout) that are now going to be in the templates. So pay close attention if any of the following changes might effect your content blocks: https://github.com/ckan/ckan/pull/1935/files |
@amercader As soon as the build passes I'm happy to merge this. What's the protocol on that at the moment? Is it something I can just do? |
@johnmartin Do you mind adding a quick note on the CHANGELOG with the changes you mention on the previous commit? They are more likely to be noticed there. Don't worry about the formatting, we'll sort it out on the actual release. Regarding the merge, you go ahead if you are happy, if not ping me and I'll do it. |
🎆 This is great news, great work @mintcanary and @johnmartin |
I've taken from
ckan:responsive-2.2
and re-git am
ed the commits into the laster master to make this easy to merge.Note: This will need a
paster front-end-build
and commit after merging: