Add ctrl+q and prepare ctrl+w keybinds#205
Closed
hugeblank wants to merge 2 commits intocinnyapp:main-backupfrom
Closed
Add ctrl+q and prepare ctrl+w keybinds#205hugeblank wants to merge 2 commits intocinnyapp:main-backupfrom
hugeblank wants to merge 2 commits intocinnyapp:main-backupfrom
Conversation
Does what title says. Lifts event handler logic from paste image support (cinnyapp#167). Includes some commented out logic for compatibility with systray (cinnyapp#166) when/if merged. Requires TRAY_LABEL be exposed as public, however.
to uncomment when cinnyapp#166 is merged.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Sep 26, 2023
Author
|
Decided to build my PR and test it in production and it doesn't work. This threw me off because it worked in the dev environment. There's an open issue tracking the inability to set global shortcuts on wayland (tauri-apps/tauri#3578), and I think that's the issue now. Guess this PR is blocked until it gets fixed. Fun. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #204
Lifts event handler logic from paste image support (#167).
Includes some commented out logic for compatibility with systray (#166) when/if merged. Requires
TRAY_LABELintray.rsbe exposed as public.If I catch that the referenced PRs get merged before this one I'll resolve conflicts and uncomment code as necessary. That said, this PR on its own is ready to be merged if the maintainers want to handle the conflicts and changes I've mentioned.
Type of change
Checklist: