support pipe connection (--remote-debugging-pipe)
#867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fields have this comment: "reuse the easyjson structs to avoid allocs per Read/Write" But I don't see how it will reduce the allocs. Maybe this statement does not stand any more due to code changes? The benchmark shows there is not big difference: name old time/op new time/op delta TabNavigate-8 10.8ms ± 6% 10.6ms ± 3% ~ (p=0.218 n=10+10) name old alloc/op new alloc/op delta TabNavigate-8 288kB ± 1% 287kB ± 1% ~ (p=0.133 n=9+10) name old allocs/op new allocs/op delta TabNavigate-8 1.60k ± 1% 1.59k ± 1% ~ (p=0.189 n=9+10)
So that it can accept other implementations of the Transport interface. The purpose is to make it support --remote-debugging-pipe.
Note that pipe connection is just supported on non-windows as of now. see golang/go#21085.
this commit just contains format changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #401
This PR implements
Transportwith a pipe connection.Notes:
chromedp.DebuggingPortto force it to use WebSocket connectionCHROMEDP_WS=1to force the unit tests to use WebSocket connectionsQuestion:
I think
chromedp.Transportandchromedp.Connshould be un-exported:chromedp.Transport->chromedp.transportchromedp.Conn->chromedp.wsConnShould we do this?