add the MouseMoveNode function #787
Conversation
ZekeLu
left a comment
ZekeLu
left a comment
There was a problem hiding this comment.
And can you please add unit tests for the new funcs?
|
|
||
|
|
||
|
|
||
|
|
|
|
||
|
|
||
|
|
||
|
|
|
|
||
|
|
||
|
|
||
|
|
|
|
||
|
|
||
|
|
||
|
|
| Type: input.MouseMoved, | ||
| X: x, | ||
| Y: y, | ||
| } |
There was a problem hiding this comment.
better to use the constructor func?
p := input.DispatchMouseEvent(input.MouseMoved, x, y)There was a problem hiding this comment.
Yes, I just noticed this function here, it did the thing what I’m looking for for MouseMoveXY
|
|
||
|
|
||
| func MouseMoveNode(n *cdp.Node, opts ...MouseOption) MouseAction { | ||
| return ActionFunc(func(ctx context.Context) error { |
There was a problem hiding this comment.
MouseClickNode does some check and scrolls the node into view, should we do the same here? If the answer is yes, maybe we should extract those code into a func.
There was a problem hiding this comment.
The MouseMoveNode function is the similar function to the MouseClickNode, but it doesn’t do the click movement, just put the mouse on the target node.
|
@rn0l485 A better way to abstract it in Rod: https://github.com/go-rod/rod/blob/d7b838112a1a30304d0c7afd759e1a9608066a93/element.go#L72-L81 page.MustElement("button").MustHover()Hover the mouse over the center of the element. |
4 participants
Hi,
I just add a function for moving the mouse to the target node.