Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New animation option - similar to UICalloutView in Maps.app #1

Closed
wants to merge 1 commit into from
Closed

Conversation

myell0w
Copy link
Contributor

@myell0w myell0w commented Mar 22, 2011

No description provided.

@chrismiles
Copy link
Owner

Thanks, I've merged this in.

Note, I removed your xcode workspace/userdata files. They shouldn't be added to the repository.

Also, the last part of the "pop" effect looks like it jumps (not smooth) in the simulator. I haven't had a chance to test on device yet, but wanted to check if the pop animation was smooth for you?

@myell0w
Copy link
Contributor Author

myell0w commented Mar 28, 2011

Yeah, thanks. Sorry for the workspace/userdata, haven't yet added the xcode4-stuff to my global gitignore-file. The animation jumps, yes. If you wrap the code in animationDidStop into a UIView-Animation everything should be smooth. By the way, I wrote, based on your PopTipView a clone of the private UICalloutView that behaves and looks similar, I will release it as a different project if you don't mind.

@chrismiles
Copy link
Owner

I have cleaned up the pop animation and fixed view positioning when presented without animation.

No problem with the other project based on the idea, the more the merrier.

@chrismiles chrismiles closed this May 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants