Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: limit for buy open orders/open trades #311

Merged
merged 5 commits into from
Sep 19, 2021
Merged

feat: limit for buy open orders/open trades #311

merged 5 commits into from
Sep 19, 2021

Conversation

chrisleekr
Copy link
Owner

Description

This feature will prevent placing the buy order based on the number of buy open orders or the number of open trades.

Related Issue

#147 #304

Motivation and Context

The risk has been raised when there are big drops in the market, the bot tries to buy all coins that reached the lowest price. As a result, it uses up all the available quote assets.

How Has This Been Tested?

Test coverage.

Screenshots (if appropriate):

image

image

This was linked to issues Sep 12, 2021
Add limit for total number of active coins #147
Closed
feat(configuration): max opened positions #304
Closed
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021 •
edited
Loading

Codecov Report

Merging #311 (54a22fd) into master (20d34fd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        76    +1     
  Lines         2589      2642   +53     
  Branches       447       456    +9     
=========================================
+ Hits          2589      2642   +53
Impacted Files Coverage Δ
app/cronjob/trailingTradeIndicator.js 100.00% <ø> (ø)
app/frontend/websocket/handlers/latest.js 100.00% <ø> (ø)
app/cronjob/trailingTrade/step/determine-action.js 100.00% <100.00%> (ø)
...lingTrade/step/ensure-grid-trade-order-executed.js 100.00% <100.00%> (ø)
app/cronjob/trailingTrade/step/place-buy-order.js 100.00% <100.00%> (ø)
...ronjob/trailingTrade/step/remove-last-buy-price.js 100.00% <100.00%> (ø)
app/cronjob/trailingTradeHelper/common.js 100.00% <100.00%> (ø)
...job/trailingTradeIndicator/step/get-order-stats.js 100.00% <100.00%> (ø)
app/cronjob/trailingTradeIndicator/steps.js 100.00% <100.00%> (ø)
app/helpers/mongo.js 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d34fd...54a22fd. Read the comment docs.

@chrisleekr chrisleekr merged commit 05a9edf into master Sep 19, 2021
@chrisleekr chrisleekr mentioned this pull request Sep 24, 2021
Closed
@chrisleekr chrisleekr deleted the feat/maximum-open-orders branch September 29, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(configuration): max opened positions Add limit for total number of active coins
2 participants
@chrisleekr @codecov-commenter