Update chainer version 4.0.0rc1 / 3.5 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwiwi
suggested changes
Mar 23, 2018
chainermn/links/n_step_rnn.py
Outdated
|
|
||
| else: # expect Chainer >4.0.0b3 | ||
| check_lstm = issubclass( | ||
| link.__class__, lconn.n_step_rnn.NStepRNNBase) |
There was a problem hiding this comment.
Isn't it more natural to use isinstance(link, lconn.n_step_rnn.NStepRNNBase) ?
There was a problem hiding this comment.
I'm not confident, but I guess it's safer to use issubclass. Do you think we can assume link is a direct instance of NStepRNNBase ?
There was a problem hiding this comment.
isinstance returns True for instances of sub classes.
In [1]: class A(): pass
In [2]: class B(A): pass
In [3]: a = A()
In [4]: b = B()
In [5]: isinstance(a, A)
Out[5]: True
In [6]: isinstance(b, A)
Out[6]: True
There was a problem hiding this comment.
I see, thanks. I will fix this.
iwiwi
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #220 and #222 (with further version update).
The two pull requests have a circular dependency and must be fixed together.