Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding comments #107

Merged
merged 3 commits into from
Aug 17, 2017
Merged

Adding comments #107

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
189d447
Remove unnecessary comment
iwiwi Aug 15, 2017
de0ff50
Describe why we don't use MPI4py's scatter
iwiwi Aug 15, 2017
9730427
Describe why we delay the communicator initialization
iwiwi Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove unnecessary comment
  • Loading branch information
@iwiwi
iwiwi committed Aug 15, 2017
commit 189d4470efd03bf07d91034a75bae3e3a3c5b598
2 changes: 0 additions & 2 deletions chainermn/communicators/hierarchical_communicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ def allreduce_grad(self, model):
self.gpu_buffer_a.ptr(), self.gpu_buffer_b.ptr(), n_elems_total,
nccl.NCCL_FLOAT, nccl.NCCL_SUM, 0, stream.ptr)

# TODO(akiba): sync necessary?

# Inter-node allreduce
if self.intra_rank == 0:
_communication_utility.inter_allreduce_gpu(
Expand Down