Fix Path.add_path() #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiggins
commented
Mar 19, 2021
Comment on lines
+171
to
+172
| cdef _vertex_source.PathSource* othr = <_vertex_source.PathSource*>other._this | ||
| pth.concat_path[_vertex_source.PathSource](dereference(othr)) |
There was a problem hiding this comment.
othr was pointing to self._this instead of other._this 😑
jwiggins
commented
Mar 19, 2021
Comment on lines
+92
to
+94
| void concat_path(VertexSource& vs) | ||
| { | ||
| m_path.concat_path(vs, path_id); | ||
| m_path.concat_path(vs); |
There was a problem hiding this comment.
The way that agg::path_storage::concat_path is used by this code doesn't require the second argument, which sets the starting vertex index in the source which is being added to the receiver. It's always 0 because we want to copy the whole source from its start.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been broken since it was introduced... Stupid copypasta 🍝