Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Support #4

Closed
jwiggins opened this issue Nov 2, 2016 · 4 comments
Closed

Windows Support #4

jwiggins opened this issue Nov 2, 2016 · 4 comments

Comments

@jwiggins
Copy link
Member

jwiggins commented Nov 2, 2016

Windows probably works, but it hasn't been tested at all

@jdeschenes
Copy link
Contributor

jdeschenes commented Jul 23, 2017

Before closing that task I think there are a few other lingering issues that should be resolved:

  • appveyor builds should be integrated
  • clean should be tweaked

@jwiggins
Copy link
Member Author

@jdeschenes: I think this can be closed now but I don't know what you mean by "clean should be tweaked".

@jdeschenes
Copy link
Contributor

Hi @jwiggins, it's been a while! This is an embarassingly terse comment, sorry about that. I am afraid I do not fully recall.

My guess is it could be related to the clean method

python setup.py clean

It does not fully clean the build artifacts(e.g. _celiagg.cpp is not cleaned up)
This was a pain point for me a few years back. Sometimes, even though I made some code changes, no change were detected and thus no cythonization occurred. I was compiling against an old version of the code. I was manually deleting the cython generated files. Cleaning is significantly more convenient.

I had implemented some logic to delete the cython generated files when invoking clean so that I could be sure that I was using the latest and greatest on some of my projects.

The pandas project is doing something that resembles what I implemented in my projects.

As far as I can tell, this is not a specific problem with Windows.

I hope that was helpful.

@jwiggins
Copy link
Member Author

Thanks for clarifying. I also deal with that problem when I develop and it's not platform specific. (I've just been using git clean before rebuilding).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants