Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Support #38

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Windows Support #38

merged 1 commit into from
Jul 22, 2017

Conversation

jdeschenes
Copy link
Contributor

This is a partial fix for #4. This compiles just fine for python 3.6.

  • both -Wfatal-errors and -Wno-unused-function are not compatible with MSVC
  • Added Gdi32.lib and User32.lib as extra_link_args
  • added a #define _USE_MATH_DEFINES since M_PI is not defined in math.h

Tried briefly to compile with Python 2.7, since stdint.h is not part of VC 9.0.

@jdeschenes
Copy link
Contributor Author

We could include a stdint.h as mentionned in scrapinghub/python-crfsuite#16 in the repo to make it work for python 2.7.

@jwiggins
Copy link
Member

Thanks for the contribution!

@jwiggins jwiggins merged commit 685f0f2 into celiagg:master Jul 22, 2017
@jwiggins jwiggins mentioned this pull request Jul 22, 2017
Merged
@jdeschenes jdeschenes deleted the windows_support branch July 23, 2017 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdeschenes @jwiggins