Skip to content
This repository was archived by the owner on Jun 19, 2020. It is now read-only.

Conversation

@kensoh
Copy link
Member

@kensoh kensoh commented Aug 23, 2017

I've made a PR which somehow doesn't respect the Sphinx documentation syntax. Making an update so that the sample code block shows up as code block instead of plain text. I'm sorry for the oversight! It is my first time updating Sphinx documentation and I was not able to preview the actual change live. https://github.com/casperjs/casperjs/pull/1871/files

I've made a PR which somehow doesn't respect the Sphinx documentation syntax. Making an update so that the sample code block shows up as code block instead of plain text. I'm sorry for the oversight! It is my first time updating Sphinx documentation and I was not able to preview the actual change live. https://github.com/casperjs/casperjs/pull/1871/files
@kensoh
Copy link
Member Author

kensoh commented Aug 23, 2017

Hi @jefleponot I've made an edit to sub-branch but somehow the tests fail. Although the original edit pass. I wasn't able to edit on my fork as it doesn't show up correctly when doing diff.

@kensoh
Copy link
Member Author

kensoh commented Aug 23, 2017

Committing now as the tests now pass.

@kensoh kensoh merged commit 0b06a37 into master Aug 23, 2017
@kensoh kensoh deleted the kensoh-patch-1 branch August 23, 2017 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants